wea_ondara/MangaStatus
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

frontend: get rid of evil eval function in table sorting

Browse Source
This commit is contained in:
wea_ondara
2023-11-25 20:48:05 +01:00
parent 8b58758751
commit c21809152d
2 changed files with 28 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
frontend/src/components/manga/MangaListTable.vue
View File

@@ -6,7 +6,7 @@ import {BTable, type TableItem} from 'bootstrap-vue-next';
import type {TableField, TableFieldObject} from 'bootstrap-vue-next/dist/src/types';
import type {ViewEntry, ViewList} from '@/components/manga/MangaList.vue';
import MangaEntryDetailsModal from '@/components/manga/MangaEntryDetailsModal.vue';
import {latestChaptersSorted, latestChapterString, newChapterCount} from '@/components/manga/util.manga';
import {get, latestChaptersSorted, latestChapterString, newChapterCount} from '@/components/manga/util.manga';
type HeadData<I> = {
label: string,
@@ -89,7 +89,7 @@ export default class MangaListTable extends Vue {
if (!this.sortKey) {
return this.tableEntries;
}
const keyExtractor = (e: ViewEntry) => eval('e.' + this.sortKey);//TODO eval is evil
const keyExtractor = (e: ViewEntry) => get(e, this.sortKey);//TODO eval is evil
const comparer = (l: ViewEntry, r: ViewEntry) => {
const lkey = keyExtractor(l);
const rkey = keyExtractor(r);